make.js: trim excess whitespaces from CFLAGS and LDFLAGS #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excess whitespaces in the CFLAGS and LDFLAGS variables cause `gcc` compilation errors like `aarch64-unknown-linux-gnu-gcc: error: No such file or directory`. This is hard to debug and happens because the `.split(' ')` function will create empty `gcc` arguments, if there are any excess whitespaces in the CFLAGS and LDFLAGS environment variables. This can happen when cross-compiling using a 3rd party toolchain, which manipulates/sets the CFLAGS/LDFLAGS variables and accidentally/carelessly puts to many whitespaces in these flags. We better `trim` any whitespaces from the beginning and end of CFLAGS/LDFLAGS strings and match consecutive whitespaces within the strings via a regex instead, to avoid these nasty and hard to spot compilation errors.
|
Can i work on this? |
cjdelisle
reviewed
Jun 26, 2024
| @@ -144,7 +144,7 @@ Builder.configure({ | |||
| // with NEON on the BBB, or want to set -Os (OpenWrt) | |||
| // Allow -O0 so while debugging all variables are present. | |||
| if (CFLAGS) { | |||
| var cflags = CFLAGS.split(' '); | |||
| var cflags = CFLAGS.split.trim().split(/\s+/); | |||
There was a problem hiding this comment.
CFLAGS.split.trim().split(/\s+/); won't do what you're expecting. I think you want CFLAGS.trim().split(/\s+/);
There was a problem hiding this comment.
Sorry, I made this comment over 1 year ago but it got sucked up into a "code review" and so you never saw it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excess whitespaces in the CFLAGS and LDFLAGS variables cause
gcccompilation errors likeaarch64-unknown-linux-gnu-gcc: error: No such file or directory. This is hard to debug and happens because the.split(' ')function will create emptygccarguments, if there are any excess whitespaces in the CFLAGS and LDFLAGS environment variables. This can happen when cross-compiling using a 3rd party toolchain, which manipulates/sets the CFLAGS/LDFLAGS variables and accidentally/carelessly puts to many whitespaces in these flags. We bettertrimany whitespaces from the beginning and end of CFLAGS/LDFLAGS strings and match consecutive whitespaces within the strings via a regex instead, to avoid these nasty and hard to spot compilation errors.